[feat] remove i18n-unrelated code in provacy-policy page #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ephemeral-sable-89c7e0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
josix
approved these changes
Apr 13, 2024
|
LGTM, could you help create another PR to propose the change for the CSS coding style refactor, I think that would be easier to have discussion on it~ |
PR #512 has been opened as a POC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
label: 'https://i.imgur.com/cVjN760.jpg'ini18n/about/privacy-policy.i18n.jsterms.contactand move it in template (terms.contactdoesn't require translation){licenseTitle}for better maintenanceRelated Issue
#499
Additional Context
I was also going to rewrite the styling in
pages/about/privacy-policy.vuewith respect to #396,but found that tailwind inline classes will be overridden by ones in
I18nPageWrapper.Maybe we could add
important: trueintailwind.config.jsto make switching to tailwind css easier?